Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new TestLogger #57

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Create a new TestLogger #57

merged 1 commit into from
Nov 20, 2018

Conversation

gmponos
Copy link
Contributor

@gmponos gmponos commented Nov 20, 2018

Created a new TestLogger according to
Seldaek/monolog#1229

@Jean85
Copy link
Member

Jean85 commented Nov 20, 2018

@Seldaek you're the editor for this PSR, so you have to evaluate if this is a BC of the spec or can be merged without issues as an "errata".

Let me know how you want to proceed.

@Seldaek
Copy link
Collaborator

Seldaek commented Nov 20, 2018

IMO this is only about the library here (as in "util" package in other PSRs) and not related to the PSR spec itself so I'd say go for it.

@Jean85
Copy link
Member

Jean85 commented Nov 20, 2018

Good! Since you're the editor, I've given you write access to this repo.

Would you like to release it? Or should I do it?

@Jean85 Jean85 merged commit 6c001f1 into php-fig:master Nov 20, 2018
@Seldaek
Copy link
Collaborator

Seldaek commented Nov 20, 2018

Feel free to go ahead and release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants